Consistency between batching and fiber state #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00c053c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mikearnaldi
force-pushed
the
chore/work-on-batching
branch
from
7620f4e
to
02d01c3
Compare
mikearnaldi
changed the title
mikearnaldi
force-pushed
the
chore/work-on-batching
branch
9 times, most recently
from
7cd874d
to
c31fc70
Compare
mikearnaldi
force-pushed
the
chore/work-on-batching
branch
from
c31fc70
to
00c053c
Compare
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve consistency between request batching and fiber environment.
In prior releases request batching required operators that act on fiber context such as
Effect.locallyto be aware of batching in order to avoid bugs where the effect executed post batching would lose the fiber environment (context, refs, and flags).This change restructure how batching internally works, inside the fiber we now slice up the stack and restore the exact context that was destroyed, by rewriting the internals of forEach batching is now transparent to any other function that deals with fiber state.